Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Update centos Dockerfile to use new setup script from velox #22216

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

wanweitao
Copy link
Contributor

@wanweitao wanweitao commented Mar 15, 2024

Description

Update centos Dockerfile to use new setup script from velox

Motivation and Context

The Velox repository removed the script setup-circleci.sh #8454. They've switched to using setup-centos8.sh in their CI Dockerfiles. This pull request updates the Prestissimo Dockerfile to adopt the new script for consistency.

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@wanweitao wanweitao requested a review from a team as a code owner March 15, 2024 09:15
Copy link

linux-foundation-easycla bot commented Mar 15, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@wanweitao
Copy link
Contributor Author

Hi @majetideepak ! Would you help review this PR?

@majetideepak
Copy link
Collaborator

@wanweitao Were you able to test this change?

@wanweitao
Copy link
Contributor Author

wanweitao commented Mar 22, 2024

@majetideepak Yes, I tested the Dockerfile several times, and it seems that the build process was successful. However, I’m wondering if there are any additional tests I should perform?

@majetideepak
Copy link
Collaborator

@wanweitao It should be sufficient if the build succeeds using the Dockerfile. Thanks for verifying!

@majetideepak majetideepak merged commit 8b1b81a into prestodb:master Mar 22, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants