Resolve map(varchar, json) canonicalization bug #24232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
auden-woolfson and
imsayari404
and removed request for
a team
infvg
force-pushed
the
BUG_24207
branch
6 times, most recently
from
e2b74bc to
8e99d17
Compare
The map function will not sort a json object by its keys, despite the json_parse function sorting the same input. If implemented, this will sort json objects. Resolves prestodb#24207
tdcmeehan
reviewed
Dec 18, 2024
| @@ -956,8 +960,18 @@ static BlockBuilderAppender createBlockBuilderAppender(Type type) | |||
| return new VarcharBlockBuilderAppender(type); | |||
| case StandardTypes.JSON: | |||
| return (parser, blockBuilder, sqlFunctionProperties) -> { | |||
| String json = OBJECT_MAPPED_UNORDERED.writeValueAsString(parser.readValueAsTree()); | |||
| JSON.writeSlice(blockBuilder, Slices.utf8Slice(json)); | |||
| Slice slice = Slices.utf8Slice(OBJECT_MAPPED_UNORDERED.writeValueAsString(parser.readValueAsTree())); | |||
There was a problem hiding this comment.
Am I correct in understanding that this fixes two problems:
- Invalid JSON will suddenly be validated
- The contents of the map will be sorted
There was a problem hiding this comment.
Yes, invalid json (I assume in presto that refers to unsorted json) will become valid due to the sorting.
Incorrect json eg {"t":"qwdq", "qdwqd"} will still cause errors since both before and after my fix the json gets mapped to a tree object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The map function will not sort a json object by its keys, despite the json_parse function sorting the same input.
If implemented, this will sort json objects.
Description
map(varchar, json) would previously not sort the json values. Modify the map(varchar, json) to sort the resulting json value
Motivation and Context
#24207
Impact
map(varchar, json) result might have different ordering.
Test Plan
Unit test added
Contributor checklist
Release Notes