Skip to content

Commit

Permalink
Merge pull request #116 from marnen/104-fix-rake-task
Browse files Browse the repository at this point in the history
Silence logger when getting schema. [#104]
  • Loading branch information
preston committed Jun 6, 2017
2 parents 3d854dc + 1157e9d commit 328fc7a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/railroady/diagram_graph.rb
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def dot_label
"label=\"#{@diagram_type} diagram\\l" \
"Date: #{Time.now.strftime '%b %d %Y - %H:%M'}\\l" +
(defined?(ActiveRecord::Migrator) ? 'Migration version: ' \
"#{ActiveRecord::Migrator.current_version}\\l" : '') +
"#{Rails.logger.silence { ActiveRecord::Migrator.current_version } }\\l" : '') +
"Generated by #{APP_HUMAN_NAME} #{APP_VERSION}\\l" + 'http://railroady.prestonlee.com' \
"\\l\", fontsize=13]\n"
end
Expand Down

3 comments on commit 328fc7a

@thephw
Copy link

@thephw thephw commented on 328fc7a Jan 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rails.logger.silence is now deprecated so this breaks with Rails 6.

@preston
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thephw Would you by chance be interested in taking over as a maintainer of this gem? I rarely get a chance to work on it and as you can see there are a lot of tasks that have piled up.

@thephw
Copy link

@thephw thephw commented on 328fc7a May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@preston I would be interested, but I am not sure I would be able to give it sufficient time and attention right now. We are launching a new business and we do contribute back to open source, but most of our cycles right now are going to terraform/buildpacks/kubernetes tooling. I will keep it mind though when I need a break from golang land.

Please sign in to comment.