Fix hoenn pokedex palette being split in two #1990
Merged
+50
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bg_hoenn.pal was split into two palettes:
bg_hoenn.palandcaught_screen.pal, this is because in pokemon caught screen it would use the same palette loaded from different offsets to flash the palette which got misinterpreted as two different palettes when its loading the same one at different offsets. The fact that this is one palette can be proven by the fact LoadPokedexBgPalette() loadsbg_hoenn.palas a 96 byte palette.The split palette causes issues when compiler doesn't put the palettes in the same order as listed in graphics.c, causing the code to load half of the hoenn pokedex palette and other half as garbage data.
Discord contact info
nt_x86