Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added extra encoded character support #2050

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Added extra encoded character support #2050

merged 2 commits into from
Nov 25, 2024

Conversation

AsparagusEduardo
Copy link
Contributor

@AsparagusEduardo AsparagusEduardo commented Oct 19, 2024 •
edited
Loading

Description

  • Added support for CHAR_HYPHEN in mini_pchar_decode.
  • Added handling for CHAR_NEWLINE, CHAR_PROMPT_SCROLL, CHAR_PROMPT_CLEAR and CHAR_ELLIPSIS by adding multiple characters to properly print out what they're meant to print

I did this as part of a way to debug a different PR, so please let me know if this could be handled better and cleaner.

Discord contact info

AsparagusEduardo

@GriffinRichards
Copy link
Member

I get that ~ isn't in the default font so it's less likely to appear in someone's decoded string, but I'd think ? is a clearer "unknown character" indicator as it's closer to the standard replacement character.

@AsparagusEduardo
Copy link
Contributor Author

Restored ?

@GriffinRichards GriffinRichards merged commit 4beb0ef into pret:master Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AsparagusEduardo @GriffinRichards