Fix collision comparison in PlayerNotOnBikeMoving #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition was optimized to a single comparison, which made it hard to read. While making it more readable I noticed that it was treating
COLLISION_ROTATING_GATEspecially despite it not having any special behavior. The result is that walking into a rotating gate that can't rotate won't update the player avatar correctly. This looks especially weird if you try to collide with a rotating gate by changing direction.Before bug fix (walking head-on, and then trying to turn into it):
After bug fix (same inputs as above)
