Mic Test Overlay #320
Merged
Mic Test Overlay #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function I'm leaving on is breaking my brain so gonna commit and document some of the structs to the best of my ability
tgsm
reviewed
Jun 4, 2024
Stale pull request warningThis pull request has had no activity for 60 days and has been marked stale. It will be closed after a further 30 days of inactivity. |
|
this is literally a draft PR |
PikalaxALT
requested changes
Sep 28, 2024
PikalaxALT
requested changes
Oct 1, 2024
PikalaxALT
reviewed
Oct 20, 2024
PikalaxALT
requested changes
Oct 20, 2024
tgsm
requested changes
Oct 20, 2024
tgsm
reviewed
Oct 31, 2024
src/overlay_mic_test.c
Outdated
Comment on lines
615
to
627
| // TODO: Is this a library struct? | ||
| typedef struct UnkStruct_27E0000 { | ||
| u8 unk_0000[0x3FF8]; | ||
| u32 unk_3FF8; | ||
| } UnkStruct_27E0000; | ||
|
|
||
| static void MicTest_VBlankIntrCB(void *data) { | ||
| MicTestData *micTest = data; | ||
| NNS_GfdDoVramTransfer(); | ||
| ov62_021E5FC4(micTest); | ||
| ov62_021E60D4(&micTest->unkB8); | ||
| UnkStruct_27E0000 *unkStruct = (UnkStruct_27E0000 *)(0x27e0000); | ||
| unkStruct->unk_3FF8 |= 1; |
tgsm
approved these changes
Nov 1, 2024
PikalaxALT
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows from #311