-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port render_text.s from Diamond, decompile diffs #335
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things + merge main into the branch
src/render_text.c
Outdated
|
||
static BOOL sub_020021A0(TextPrinterSubStruct *subStruct); | ||
static BOOL sub_02002220(void); | ||
static void TextPrinterInitDownArrowCounters(TextPrinter *printer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TextPrinter -> TextPrinter_
src/render_text.c
Outdated
return RENDER_UPDATE; | ||
} | ||
|
||
GlyphInfo *r5 = FontID_TryLoadGlyph(subStruct->fontId, currentChar); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r5 -> glyph(Info)
u8 height = GetWindowHeight(printer->template.window) - 2; | ||
u16 r6 = unk00; | ||
|
||
FillBgTilemapRect(printer->template.window->bgConfig, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why this function doesn't just take (BgConfig, BgId, u16, u8, u8, etc)? Seems like that's the case rather than casting explicitly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was ported from diamond without modifications
No description provided.