Decompile overlay_02_02251E74.c #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as per request in discord
tgsm
requested changes
Nov 22, 2024
src/field/event_cutscene_celebi.c
Outdated
| } CelebiTimeTravelState; | ||
|
|
||
| static BOOL Task_CelebiTimeTravelCutscene(TaskManager *taskMan) { | ||
| int *state = TaskManager_GetStatePtr(taskMan); |
There was a problem hiding this comment.
I believe our .clang-format has changed since you started this file, so it should probably be run again
There was a problem hiding this comment.
looks like clang-format doesn't catch these anymore, so will fix what I can manually and if I miss some it's nbd
tgsm
approved these changes
Nov 23, 2024
Comment on lines
+83
to
+87
| a1[0] = gearPhone->unk_arr5[0]; | ||
| a1[1] = gearPhone->unk_arr5[1]; | ||
| a1[3] = gearPhone->unk_var3; | ||
| a1[4] = gearPhone->unk_var4; | ||
| a1[2] = gearPhone->unk_var7; |
There was a problem hiding this comment.
This is probably a struct, but it can be figured out later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this a draft early in case anyone sees what the heck these functions are even for so I can begin to properly document them