Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule to build sbox_gra_00000000.NCLR #354

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Add rule to build sbox_gra_00000000.NCLR #354

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a6f7abf
Add rule to build sbox_gra_00000000.NCLR
PikalaxALT Nov 10, 2024
e79e1c3
Delete files/data/sbox_gra/sbox_gra_00000000.NCLR
PikalaxALT Nov 10, 2024
1fde0d5
Update sbox_gra.mk
PikalaxALT Nov 10, 2024
5e4f00b
this rule needs to be explicit
PikalaxALT Nov 10, 2024
8ccfa66
simplify sbox_gra filename; add .knarcorder
PikalaxALT Nov 11, 2024
6e4c030
Merge branch 'master' into hotfix/sbox_gra
adrienntindall Nov 14, 2024
8af4788
Merge branch 'master' into hotfix/sbox_gra
adrienntindall Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions files/data/sbox_gra.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,12 @@ SBOX_GRA_FILES := \
sbox_gra_00000000.NCLR \
sbox_gra_00000001.NCGR

4BPP_NOPAD_PCMP_NCLR_FILES += $(SBOX_GRA_DIR)/sbox_gra_00000000.NCLR
VERSION101_SOPC_NCGR_FILES += $(SBOX_GRA_DIR)/sbox_gra_00000001.NCGR

$(SBOX_GRA_DIR)/sbox_gra_00000000.NCLR: $(SBOX_GRA_DIR)/sbox_gra_00000001.png
$(GFX) $< $@ $(GFX_FLAGS)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should already be handled in graphics_files_rule.mk

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case the stems do not match. graphics_files_rules.mk only handles the cases where the stems do match.


$(SBOX_GRA_NARC): $(addprefix $(SBOX_GRA_DIR)/,$(SBOX_GRA_FILES))

clean-sbox-gra:
Expand Down
Binary file removed files/data/sbox_gra/sbox_gra_00000000.NCLR
View file
Open in desktop
Binary file not shown.