Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce fullControl option, allowing fine-grain control from ESLint #613

Closed
wants to merge 1 commit into from

Conversation

antfu
Copy link

@antfu antfu commented Dec 2, 2023

A solution to fix #612

Copy link

changeset-bot bot commented Dec 2, 2023

⚠️ No Changeset found

Latest commit: a333607

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JounQin
Copy link
Member

JounQin commented Dec 2, 2023

Let's discuss at #612 first.

Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #612 (comment) I am strongly opposed to this PR.

Adding new options is undesirable, as it goes against the aims of this project.

I'll leave this PR open for the moment, so you can read my rational in that comment.

@antfu antfu closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow only formatting code snippets in markdown, not the markdown file itself
3 participants