fix: parameter comment function attribute removal (#2412)

* fix: attributes are getting printed now if any (not the last) parameter have a line comment * chore: add newline * chore: snapshot generation --------- Co-authored-by: Simon Schwedes <[email protected]>
prettier · Jan 20, 2025 · c5c56ff · c5c56ff
1 parent 718f71d
commit c5c56ff
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 2 deletions.
diff --git a/src/printer.mjs b/src/printer.mjs
@@ -1410,7 +1410,7 @@ function printFunction(path, options, print) {
   const willBreakDeclaration = declaration.some(willBreak);
 
   if (willBreakDeclaration) {
-    return [printedDeclaration, " ", printedBody];
+    return [...declAttrs, printedDeclaration, " ", printedBody];
   }
 
   return [

diff --git a/tests/attributes/__snapshots__/jsfmt.spec.mjs.snap b/tests/attributes/__snapshots__/jsfmt.spec.mjs.snap
@@ -90,6 +90,28 @@ class Test
     }
 
 }
+
+class ParamCommentFunctionAnnotation {
+
+    #[Foo]
+    function bar(
+        int $a, // parameter comment
+        int $b,
+    ) {
+        return $a + $b;
+    }
+
+    #[Foo]
+    function bar2(
+        int $a,
+        int $middle, // parameter comment
+        int $b,
+    ) {
+        return $a + $middle + $b;
+    }
+
+}
+
 =====================================output=====================================
 <?php
 
@@ -206,5 +228,25 @@ class Test
     }
 }
 
+class ParamCommentFunctionAnnotation
+{
+    #[Foo]
+    function bar(
+        int $a, // parameter comment
+        int $b
+    ) {
+        return $a + $b;
+    }
+
+    #[Foo]
+    function bar2(
+        int $a,
+        int $middle, // parameter comment
+        int $b
+    ) {
+        return $a + $middle + $b;
+    }
+}
+
 ================================================================================
 `;
diff --git a/tests/attributes/attributes.php b/tests/attributes/attributes.php
@@ -81,4 +81,25 @@ public function withAttribute(string $foo): string
         return $foo;
     }
 
-}
+}
+
+class ParamCommentFunctionAnnotation {
+
+    #[Foo]
+    function bar(
+        int $a, // parameter comment
+        int $b,
+    ) {
+        return $a + $b;
+    }
+
+    #[Foo]
+    function bar2(
+        int $a,
+        int $middle, // parameter comment
+        int $b,
+    ) {
+        return $a + $middle + $b;
+    }
+
+}