Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing options #87

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Testing options #87

wants to merge 18 commits into from

Conversation

nickserv
Copy link
Member

@nickserv nickserv commented Nov 7, 2019 •
edited
Loading

#53

  • Create fully-functioning chrome.extension.storage.sync stub Use sinon-chrome with webextension-polyfill
  • Test option syncing behavior

@nickserv nickserv mentioned this pull request Nov 7, 2019
Open
9 tasks
@kaicataldo
Copy link
Member

What's the status on this?

@nickserv
Copy link
Member Author

I've fixed merge conflicts and several configuration issues. Now that we're using sinon-chrome we no longer need to develop complex mocks and can just focus on implementing the options tests (mainly interested in syncing behavior).

Base automatically changed from master to main February 1, 2021 03:57
@kaicataldo
Copy link
Member

Are you still working on this? If not, I think it would be best to close the PR for now so others can feel free to work on it (would love to land this PR if you're still working on it, though!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickserv @kaicataldo