Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #281

Merged
merged 4 commits into from
Sep 29, 2022
Merged

chore: update dependencies #281

merged 4 commits into from
Sep 29, 2022

Conversation

fisker
Copy link
Member

@fisker fisker commented Sep 28, 2022

No description provided.

@fisker
Copy link
Member Author

fisker commented Sep 28, 2022

@fisker fisker closed this Sep 28, 2022
@fisker fisker reopened this Sep 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (34b2ea4) compared to base (dc1ce95).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #281   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           78        78           
  Lines          781       775    -6     
  Branches       129       129           
=========================================
- Hits           781       775    -6     
Impacted Files Coverage Δ
src/factories/flow-collection.ts 100.00% <ø> (ø)
src/transform.ts 100.00% <ø> (ø)
src/utils/group-cst-flow-collection-items.ts 100.00% <ø> (ø)
src/attach.ts 100.00% <100.00%> (ø)
src/parse.ts 100.00% <100.00%> (ø)
src/transforms/document.ts 100.00% <100.00%> (ø)
src/transforms/flow-map.ts 100.00% <100.00%> (ø)
src/transforms/flow-seq.ts 100.00% <100.00%> (ø)
src/utils/define-parents.ts 100.00% <100.00%> (ø)
src/utils/update-positions.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -108,7 +108,7 @@ function initNodeTable(nodeTable: NodeTable, node: YamlUnistNode): void {
}

if ("children" in node) {
(node.children as Array<(typeof node.children)[number]>).forEach(child => {
(node.children as Array<typeof node.children[number]>).forEach(child => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thorn0 @sosukesuzuki Is this expected? As one not familiar with TS, it's unreadable to me. I can't find when we changed this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this too. Looks bad.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure it was me in prettier/prettier#6605, not intentionally.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange thing is nobody complain about it for 3 years. I even thought this changes syntax.

@fisker fisker marked this pull request as ready for review September 28, 2022 11:11
@fisker fisker merged commit df7a20a into prettier:main Sep 29, 2022
@fisker fisker deleted the deps branch September 29, 2022 02:01
@fisker fisker mentioned this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants