-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies #281
Conversation
@thorn0 @sosukesuzuki |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 78 78
Lines 781 775 -6
Branches 129 129
=========================================
- Hits 781 775 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -108,7 +108,7 @@ function initNodeTable(nodeTable: NodeTable, node: YamlUnistNode): void { | |||
} | |||
|
|||
if ("children" in node) { | |||
(node.children as Array<(typeof node.children)[number]>).forEach(child => { | |||
(node.children as Array<typeof node.children[number]>).forEach(child => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thorn0 @sosukesuzuki Is this expected? As one not familiar with TS, it's unreadable to me. I can't find when we changed this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed this too. Looks bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure it was me in prettier/prettier#6605, not intentionally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange thing is nobody complain about it for 3 years. I even thought this changes syntax.
No description provided.