-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix import/export path #289
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 77 77
Lines 530 530
Branches 131 131
=========================================
Hits 530 530
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -3,18 +3,22 @@ | |||
// tslint:disable:variable-name | |||
|
|||
import YAML from "yaml"; | |||
import { CST } from "yaml/parse-cst.js"; | |||
// eslint-disable-next-line import/extensions | |||
import { CST } from "yaml/parse-cst"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should these imports be without extensions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old yaml use
"exports": {
".": "./index.js",
"./parse-cst": "./parse-cst.js",
"./types": [
{
"import": "./types.mjs"
},
"./types.js"
],
"./util": [
{
"import": "./util.mjs"
},
"./util.js"
],
"./": "./" // <-- problem
},
, can't be import with yaml/parse-cst.js
, but can be imported with yaml/parse-cst
.
No description provided.