Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require fully qualified global functions. #69

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Require fully qualified global functions. #69

merged 3 commits into from
Jun 4, 2024

Conversation

kimpepper
Copy link
Member

@kimpepper kimpepper requested a review from dpi September 8, 2023 03:12
@dpi
Copy link
Member

dpi commented Sep 14, 2023

I'd say its at odd with public drupal coding standards.

Personally, I dont mind prepending backslash on builtins.

Can we adapt one of the existing test cases?

@dpi
Copy link
Member

dpi commented Sep 14, 2023

Also document it + rationale in README.

@dpi
Copy link
Member

dpi commented Sep 14, 2023

Should we mention how to configure phpstorm?

This could be added to the readme.

Copy link
Member

@dpi dpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests: adapt from existing

document it + rationale in README.

@dpi
Copy link
Member

dpi commented May 13, 2024

Fixes #80

@dpi dpi merged commit 19ca952 into main Jun 4, 2024
12 checks passed
@dpi dpi deleted the global-functions branch June 4, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants