[DEV-11478] Support different layouts for Embed
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1himself
reviewed
Aug 28, 2023
Comment on lines
+13
to
+16
| &--contained { | ||
| margin-left: auto; | ||
| margin-right: auto; | ||
| } |
There was a problem hiding this comment.
Is this necessary? As far as I understand, embeds were always contained before, and it worked. Right?
There was a problem hiding this comment.
They had 0px for the left and right margin:
Plus, I guess having the --contained modifier allows for more customization from outside for people using this, so it's good.
Do you think it makes sense to update the Storybook with the new layouts as well?
There was a problem hiding this comment.
Do you think it makes sense to update the Storybook with the new layouts as well?
Absolutely! 👍
There was a problem hiding this comment.
Added: 8ee61e9
In order to get this panel in Storybook:
Do this:
- Press
aon keyboard - Then press
d
That's just how weird Storybook is.
mohammadxali
deleted the
feature/dev-11478-support-embednode-layout-in-prezlycontent-renderer-react-js
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.