Fix - Revert responsive behaviour of tables #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kudlajz
force-pushed
the
revert/care-5666-wide-tables-not-working-properly
branch
from
ef7ad8c
to
e61cea9
Compare
kudlajz
changed the title
mohammadxali
approved these changes
Jul 9, 2024
kudlajz
force-pushed
the
revert/care-5666-wide-tables-not-working-properly
branch
from
e61cea9
to
a142ebf
Compare
kudlajz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #87 since the tables do not look great in production newsrooms with
white-space: nowraprule.It will still allow the table to be scrollable on smaller screens, but will preserve the same visuals for normal screens.Turns out the browser will still break the whitespace as needed, so the responsive behaviour does not seem to kick in in most cases. So just reverting that completely.