[NAYB-109] refactor: 회원의 등급 업데이트 로직 리팩토링 #115
Merged
+39
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hseong3243
requested review from
pushedrumex,
funnysunny08,
seongHyun-Min,
Seongju-Lee and
bjo6300
as code owners
bjo6300
approved these changes
Sep 19, 2023
| @Component | ||
| @RequiredArgsConstructor | ||
| @EnableSchedulerLock(defaultLockAtMostFor = "PT60S") | ||
| public class GradeScheduler { |
There was a problem hiding this comment.
스케줄러 어노테이션이랑 함께 사용하면 트랜잭션 AOP가 제대로 적용되지 않는다고 문제가 종종 발생한다고 하더라고요. 그 때문에 분리하였습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 사항
@Scheduled를 별도의 스케줄러 클래스로 분리하였습니다.📝 작업 요약
GradeService로부터 스케줄링 어노테이션을GradeScheduler로 분리GradeServiceupdateUserGrade메서드가 호출하는 리포지토리 쿼리를 페이지네이션에서 일괄 조회로 변경💡 관련 이슈