[NAYB-158] feat: 사용자는 배달 상태가 변경되면 알림을 받아볼 수 있다. #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hseong3243
requested review from
pushedrumex,
funnysunny08,
seongHyun-Min,
Seongju-Lee and
bjo6300
as code owners
bjo6300
approved these changes
Sep 21, 2023
Seongju-Lee
approved these changes
Sep 21, 2023
bjo6300
approved these changes
Sep 21, 2023
| return delivery.getDeliveryId(); | ||
| } | ||
|
|
||
| private void sendRegisterDeliveryNotification( |
There was a problem hiding this comment.
알림이 많아지면 비즈니스 로직에 영향을 줄 수 있어서 비동기로 처리하면 좋다고 생각하는데 어떻게 생각하시나요??
There was a problem hiding this comment.
좀 더 알아보고 적용시켜 보겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 사항
notification패키지 하위의NotificationMessage에서 관리합니다.MessageFormat.format()에 인자로 전달해줄 패턴 형식으로 추가하였습니다. 더 괜찮은 방식이 있다면 의견 부탁드립니다.📝 작업 요약
notificationService.sendNotification()를DeliveryServiceregisterDelivery(),startDelivery(),completeDelivery()에서 호출💡 관련 이슈