Skip to content

Commit

Permalink
add z-index to icon button in password input in order to make it clic…
Browse files Browse the repository at this point in the history
…kable
  • Loading branch information
abautist committed Nov 13, 2024
1 parent ecc2e6f commit 82c6bfe
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "pcln-design-system",
"comment": "add zindex to IconButton in PasswordInput",
"type": "patch"
}
],
"packageName": "pcln-design-system"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "pcln-icons",
"comment": "",
"type": "none"
}
],
"packageName": "pcln-icons"
}
6 changes: 5 additions & 1 deletion packages/core/src/PasswordInput/PasswordInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ const NoWrapText = styled(Text)`
white-space: nowrap;
`

const ClickableIconButton = styled(IconButton)`
z-index: 1;
`

const maxProgressBarLength = 4

/**
Expand Down Expand Up @@ -96,7 +100,7 @@ export function PasswordInput({
autoComplete={autoComplete}
/>
{showCheckIcon && <Check color='secondary' data-testid='check-mark-icon' />}
<IconButton
<ClickableIconButton
title='visibility-button'
icon={<VisibilityIcon color='text.light' />}
onClick={changeVisibility}
Expand Down
6 changes: 3 additions & 3 deletions packages/icons/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@ export { default as Cancel } from './Cancel.jsx'
export { default as CarAutomatic } from './CarAutomatic.jsx'
export { default as CarCircle } from './CarCircle.jsx'
export { default as CarDoor } from './CarDoor.jsx'
export { default as CardTravel } from './CardTravel.jsx'
export { default as CarManual } from './CarManual.jsx'
export { default as CarWash } from './CarWash.jsx'
export { default as CardTravel } from './CardTravel.jsx'
export { default as Carriage } from './Carriage.jsx'
export { default as CarryOnBag } from './CarryOnBag.jsx'
export { default as Cars } from './Cars.jsx'
export { default as CarsBrand } from './CarsBrand.jsx'
export { default as CarWash } from './CarWash.jsx'
export { default as Casino } from './Casino.jsx'
export { default as Celebration } from './Celebration.jsx'
export { default as ChargeStation } from './ChargeStation.jsx'
Expand Down Expand Up @@ -126,8 +126,8 @@ export { default as Gps } from './Gps.jsx'
export { default as Graph } from './Graph.jsx'
export { default as Grid } from './Grid.jsx'
export { default as Group } from './Group.jsx'
export { default as Guests } from './Guests.jsx'
export { default as GuestScore } from './GuestScore.jsx'
export { default as Guests } from './Guests.jsx'
export { default as Help } from './Help.jsx'
export { default as History } from './History.jsx'
export { default as Home } from './Home.jsx'
Expand Down

0 comments on commit 82c6bfe

Please sign in to comment.