-
Notifications
You must be signed in to change notification settings - Fork 120
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SITE-23502 - resolving SSR issues with carousel. (#1512)
* adding SSR check & default Width * change file * adding lockedWidth prop and SSR handling logic * reverting changes to helpers * adding storyfix * exporting getVisibleSlides * lockedWidth and SSR test * adjusted to use lockedWidth and add controls to storybook * removing console log * Update SITE-23502_2024-09-09-14-02.json * set isBrowser in a useEffect for hydration issues * adding helper useIsBrowser * space * refactoring useResponsiveSlides * removing fn call * reworking isBrowser usage * removing untouched file * removing lockedWidth prop & fixing up useResponsive * removing unused fn & trest * rush change * fixing exports * hopefully fixing the issue * default * comments * Delete packages/carousel/src/use * Update common/changes/pcln-carousel/SITE-23502_2024-09-09-14-02.json Co-authored-by: Craig Palermo <[email protected]> --------- Co-authored-by: Craig Palermo <[email protected]>
- Loading branch information
1 parent
c3b1059
commit bb6340b
Showing
2 changed files
with
39 additions
and
18 deletions.
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
common/changes/pcln-carousel/SITE-23502_2024-09-09-14-02.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"changes": [ | ||
{ | ||
"packageName": "pcln-carousel", | ||
"comment": "Adding SSR check to no prevent crashes", | ||
"type": "minor" | ||
} | ||
], | ||
"packageName": "pcln-carousel" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters