feat(HTL-109459): multiroom drawer) #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fareedahmad1
commented
Oct 23, 2024
| export const DrawerWrapper = styled(Absolute)` | ||
| ${({ placement }) => | ||
| export const DrawerWrapper = styled(Box)` | ||
| position: fixed; |
There was a problem hiding this comment.
making the drawer fixed instead of absolute
fareedahmad1
commented
Oct 23, 2024
| isMobile?: boolean | ||
| isOpen?: boolean | ||
| isDraggable?: boolean |
There was a problem hiding this comment.
ability to enable/disable the swipe to dismiss animation
craigpalermo
approved these changes
Oct 24, 2024
fareedahmad1
force-pushed
the
feat/HTL-109459-multiroom-drawer
branch
from
69e1aaf to
6e68b40
Compare
fareedahmad1
commented
Oct 24, 2024
| ` | ||
| position: ${position || 'absolute'}; |
There was a problem hiding this comment.
allow position to be set by prop
sdalonzo
approved these changes
Oct 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1523 +/- ##
==========================================
+ Coverage 93.72% 93.76% +0.03%
==========================================
Files 149 149
Lines 11279 11284 +5
Branches 683 687 +4
==========================================
+ Hits 10571 10580 +9
+ Misses 684 681 -3
+ Partials 24 23 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add zindex, modify padding, add prop to disable drag to dismiss animation