Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HTL-111103): Enable custom header for drawer component #1528

Merged
merged 9 commits into from
Nov 5, 2024

Conversation

coolestKev
Copy link
Collaborator

@coolestKev coolestKev commented Nov 5, 2024

  1. Adding a unit test to verify how custom headings behave.
  2. Removed redundant string | React.ReactNode type declaration.
Screenshot 2024-11-05 at 9 19 20 AM

@coolestKev coolestKev marked this pull request as ready for review November 5, 2024 14:34
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (326163c) to head (1175981).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
+ Coverage   93.67%   93.78%   +0.11%     
==========================================
  Files         149      149              
  Lines       11284    11284              
  Branches      686      687       +1     
==========================================
+ Hits        10570    10583      +13     
+ Misses        685      677       -8     
+ Partials       29       24       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/core/src/Drawer/Drawer.tsx Outdated Show resolved Hide resolved
packages/core/src/Drawer/Drawer.tsx Outdated Show resolved Hide resolved
packages/core/src/Drawer/Drawer.styled.tsx Show resolved Hide resolved
@coolestKev coolestKev merged commit d0c5554 into main Nov 5, 2024
10 checks passed
@coolestKev coolestKev deleted the feat/HTL-111103-drawer-component-additions branch November 5, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants