Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/htl 111365 fix props override for collapse and close #1530

Merged

Conversation

coolestKev
Copy link
Collaborator

@coolestKev coolestKev commented Nov 8, 2024

Previously this was frozen due to prop override, fixed now.
Screenshot 2024-11-08 at 11 50 25 AM

@coolestKev coolestKev marked this pull request as ready for review November 8, 2024 16:51
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.82%. Comparing base (7b5f41b) to head (a3e4655).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/Drawer/Drawer.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
+ Coverage   93.72%   93.82%   +0.10%     
==========================================
  Files         149      149              
  Lines       11293    11293              
  Branches      689      688       -1     
==========================================
+ Hits        10584    10596      +12     
+ Misses        682      677       -5     
+ Partials       27       20       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coolestKev coolestKev merged commit 3deed57 into main Nov 8, 2024
9 of 10 checks passed
@coolestKev coolestKev deleted the task/HTL-111365-fix-props-override-for-collapse-and-close branch November 8, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants