fix: onFilter function to use functional updates for improved state m…

…anagement (#7486)
primefaces · Dec 7, 2024 · adfe904 · adfe904
1 parent 682aacf
commit adfe904
Showing 1 changed file with 21 additions and 18 deletions.
diff --git a/components/lib/treetable/TreeTable.js b/components/lib/treetable/TreeTable.js
@@ -494,27 +494,30 @@ export const TreeTable = React.forwardRef((inProps, ref) => {
     };
 
     const onFilter = (event) => {
-        let filters = getFilters();
-        let newFilters = filters ? { ...filters } : {};
+        setFiltersState((prevFilters) => {
+            const filters = props.onFilter ? props.filters : prevFilters;
+            const newFilters = filters ? { ...filters } : {};
+
+            if (!isFilterBlank(event.value)) {
+                newFilters[event.field] = { value: event.value, matchMode: event.matchMode };
+            } else if (newFilters[event.field]) {
+                delete newFilters[event.field];
+            }
 
-        if (!isFilterBlank(event.value)) {
-            newFilters[event.field] = { value: event.value, matchMode: event.matchMode };
-        } else if (newFilters[event.field]) {
-            delete newFilters[event.field];
-        }
+            if (props.onFilter) {
+                props.onFilter({
+                    filters: newFilters
+                });
+            } else {
+                setFirstState(0);
+            }
 
-        if (props.onFilter) {
-            props.onFilter({
-                filters: newFilters
-            });
-        } else {
-            setFirstState(0);
-            setFiltersState(newFilters);
-        }
+            if (props.onValueChange) {
+                props.onValueChange(processedData({ filters: newFilters }));
+            }
 
-        if (props.onValueChange) {
-            props.onValueChange(processedData({ filters: newFilters }));
-        }
+            return newFilters;
+        });
     };
 
     const cloneFilters = (filters) => {