Fix #7045: MenuItem remove aria-hidden (#7562)

primefaces · Jan 3, 2025 · ba44811 · ba44811
1 parent 99be44f
commit ba44811
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 9 deletions.
diff --git a/components/lib/contextmenu/ContextMenuSub.js b/components/lib/contextmenu/ContextMenuSub.js
@@ -222,7 +222,6 @@ export const ContextMenuSub = React.memo(
             const actionProps = mergeProps(
                 {
                     href: item.url || '#',
-                    'aria-hidden': true,
                     tabIndex: -1,
                     className: cx('action', { item }),
                     target: item.target

diff --git a/components/lib/dock/Dock.js b/components/lib/dock/Dock.js
@@ -193,7 +193,6 @@ export const Dock = React.memo(
                     href: url || '#',
                     onFocus: (event) => event.stopPropagation(),
                     className: cx('action', { disabled }),
-                    'aria-hidden': 'true',
                     tabIndex: -1,
                     target,
                     'data-pr-tooltip': label,

diff --git a/components/lib/megamenu/MegaMenu.js b/components/lib/megamenu/MegaMenu.js
@@ -831,8 +831,7 @@ export const MegaMenu = React.memo(
                     href: item.url || '#',
                     className: cx('action', { item }),
                     target: item.target,
-                    tabIndex: '-1',
-                    'aria-hidden': true
+                    tabIndex: '-1'
                 },
                 getPTOptions(processedItem, 'action', index)
             );

diff --git a/components/lib/menu/Menu.js b/components/lib/menu/Menu.js
@@ -370,7 +370,6 @@ export const Menu = React.memo(
                     target: item.target,
                     tabIndex: '-1',
                     'aria-label': item.label,
-                    'aria-hidden': true,
                     'aria-disabled': item.disabled,
                     'data-p-disabled': item.disabled
                 },

diff --git a/components/lib/menubar/MenubarSub.js b/components/lib/menubar/MenubarSub.js
@@ -193,7 +193,6 @@ export const MenubarSub = React.memo(
                 {
                     href: item.url || '#',
                     tabIndex: '-1',
-                    'aria-hidden': 'true',
                     className: cx('action', { disabled }),
                     onFocus: (event) => event.stopPropagation(),
                     target: getItemProp(processedItem, 'target'),

diff --git a/components/lib/panelmenu/PanelMenuSub.js b/components/lib/panelmenu/PanelMenuSub.js
@@ -194,8 +194,7 @@ export const PanelMenuSub = React.memo(
                     className: cx('action', { item }),
                     target: item.target,
                     onFocus: (event) => event.stopPropagation(),
-                    tabIndex: '-1',
-                    'aria-hidden': true
+                    tabIndex: '-1'
                 },
                 getPTOptions(processedItem, 'action', index)
             );

diff --git a/components/lib/tieredmenu/TieredMenuSub.js b/components/lib/tieredmenu/TieredMenuSub.js
@@ -201,7 +201,6 @@ export const TieredMenuSub = React.memo(
             const actionProps = mergeProps(
                 {
                     href: url || '#',
-                    'aria-hidden': true,
                     tabIndex: '-1',
                     onFocus: (event) => event.stopPropagation(),
                     className: cx('action'),