Fix #4214: Screenreader improve hidden accessible #7037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
I made the same fix in PrimeReact: primefaces/primereact#7179 |
melloware
force-pushed
the
PV4214
branch
4 times, most recently
from
252dbc9 to
de20fe6
Compare
melloware
commented
Jan 2, 2025
| .p-hidden-accessible select { | ||
| transform: scale(0); | ||
| } | ||
|
|
There was a problem hiding this comment.
This must be removed as it hides the input from NVDA because it won't read anything of size 0 . I think this was a legacy PrimeFaces fix that is no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4214: Screenreader improve hidden accessible
Based on this PF ticket: primefaces/primefaces#12577
Based on NVDA: nvaccess/nvda#16300
This is the modern way to hide things but still make them screenreader visible. Tested with JAWS and NVDA