Skip to content

chore(deps-dev): bump eslint-plugin-primer-react from 5.4.0 to 7.0.1 #6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

chore(deps-dev): bump eslint-plugin-primer-react from 5.4.0 to 7.0.1 #6037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ea4ab69
chore(deps-dev): bump eslint-plugin-primer-react from 5.4.0 to 7.0.1
dependabot[bot] May 14, 2025
cc0f04c
Update components
hectahertz May 15, 2025
1478c64
Update stories
hectahertz May 15, 2025
c5dface
Update tests
hectahertz May 15, 2025
1aa7282
Fix types
hectahertz May 15, 2025
743f080
Merge branch 'main' into dependabot/npm_and_yarn/eslint-plugin-primer…
primer[bot] May 16, 2025
1c395cb
Merge branch 'main' into dependabot/npm_and_yarn/eslint-plugin-primer…
primer[bot] May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
163 changes: 160 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"eslint-plugin-mdx": "3.1.5",
"eslint-plugin-playwright": "^2.2.0",
"eslint-plugin-prettier": "5.2.3",
"eslint-plugin-primer-react": "5.4.0",
"eslint-plugin-primer-react": "7.0.1",
"eslint-plugin-react": "^7.35.5",
"eslint-plugin-react-hooks": "^5.2.0",
"eslint-plugin-ssr-friendly": "1.3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/ActionBar/ActionBar.examples.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ export const ActionbarToggle = () => {
Quote reply
</ActionList.Item>
<ActionList.Divider />
<ActionList.Item onClick={() => setEditView(true)}>
<ActionList.Item onSelect={() => setEditView(true)}>
<ActionList.LeadingVisual>
<PencilIcon />
</ActionList.LeadingVisual>
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/ActionBar/ActionBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export const ActionBar: React.FC<React.PropsWithChildren<ActionBarProps>> = prop
return (
<ActionList.Item
key={menuItemChildren}
onClick={(event: React.MouseEvent<HTMLLIElement, MouseEvent>) => {
onSelect={(event: React.MouseEvent<HTMLElement> | React.KeyboardEvent<HTMLElement>) => {
closeOverlay()
focusOnMoreMenuBtn()
typeof onClick === 'function' && onClick(event)
Expand Down
8 changes: 4 additions & 4 deletions packages/react/src/ActionList/ActionList.dev.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ export const GroupHeadingCustomClassname = () => (
<ActionList.GroupHeading className="testCustomClassnameColor" as="h3">
Repositories
</ActionList.GroupHeading>
<ActionList.Item onClick={() => {}}>app/assets/modules</ActionList.Item>
<ActionList.Item onClick={() => {}}>src/react/components</ActionList.Item>
<ActionList.Item onSelect={() => {}}>app/assets/modules</ActionList.Item>
<ActionList.Item onSelect={() => {}}>src/react/components</ActionList.Item>
</ActionList.Group>
</ActionList>
)
Expand All @@ -140,8 +140,8 @@ export const HeadingCustomClassname = () => (
</ActionList.Heading>
<ActionList.Group>
<ActionList.GroupHeading as="h3">Repositories</ActionList.GroupHeading>
<ActionList.Item onClick={() => {}}>app/assets/modules</ActionList.Item>
<ActionList.Item onClick={() => {}}>src/react/components</ActionList.Item>
<ActionList.Item onSelect={() => {}}>app/assets/modules</ActionList.Item>
<ActionList.Item onSelect={() => {}}>src/react/components</ActionList.Item>
</ActionList.Group>
</ActionList>
)
Expand Down
14 changes: 7 additions & 7 deletions packages/react/src/ActionList/ActionList.features.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,25 +55,25 @@ export const WithVisualListHeading = () => (
</ActionList.Heading>
<ActionList.Group>
<ActionList.GroupHeading as="h3">Repositories</ActionList.GroupHeading>
<ActionList.Item onClick={() => {}}>
<ActionList.Item onSelect={() => {}}>
<ActionList.LeadingVisual>
<FileDirectoryIcon />
</ActionList.LeadingVisual>
app/assets/modules
</ActionList.Item>
<ActionList.Item onClick={() => {}}>
<ActionList.Item onSelect={() => {}}>
<ActionList.LeadingVisual>
<FileDirectoryIcon />
</ActionList.LeadingVisual>
src/react/components
</ActionList.Item>
<ActionList.Item onClick={() => {}}>
<ActionList.Item onSelect={() => {}}>
<ActionList.LeadingVisual>
<FileDirectoryIcon />
</ActionList.LeadingVisual>
memex/shared-ui/components
</ActionList.Item>
<ActionList.Item onClick={() => {}}>
<ActionList.Item onSelect={() => {}}>
<ActionList.LeadingVisual>
<FileDirectoryIcon />
</ActionList.LeadingVisual>
Expand All @@ -83,19 +83,19 @@ export const WithVisualListHeading = () => (

<ActionList.Group>
<ActionList.GroupHeading as="h3">Advanced</ActionList.GroupHeading>
<ActionList.Item onClick={() => {}}>
<ActionList.Item onSelect={() => {}}>
<ActionList.LeadingVisual>
<PlusCircleIcon />
</ActionList.LeadingVisual>
Owner
</ActionList.Item>
<ActionList.Item onClick={() => {}}>
<ActionList.Item onSelect={() => {}}>
<ActionList.LeadingVisual>
<PlusCircleIcon />
</ActionList.LeadingVisual>
Symbol
</ActionList.Item>
<ActionList.Item onClick={() => {}}>
<ActionList.Item onSelect={() => {}}>
<ActionList.LeadingVisual>
<PlusCircleIcon />
</ActionList.LeadingVisual>
Expand Down
12 changes: 6 additions & 6 deletions packages/react/src/ActionMenu/ActionMenu.examples.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,13 +413,13 @@ export const MultipleSections = () => {
<ActionList>
<ActionList.Group>
<ActionList.GroupHeading>Raw file content</ActionList.GroupHeading>
<ActionList.Item onClick={() => alert('Workflows clicked')}>Download</ActionList.Item>
<ActionList.Item onSelect={() => alert('Workflows clicked')}>Download</ActionList.Item>
<ActionList.Divider />
<ActionList.Item onClick={() => alert('Workflows clicked')}>Jump to line</ActionList.Item>
<ActionList.Item onClick={() => alert('Workflows clicked')}>Find in file</ActionList.Item>
<ActionList.Item onSelect={() => alert('Workflows clicked')}>Jump to line</ActionList.Item>
<ActionList.Item onSelect={() => alert('Workflows clicked')}>Find in file</ActionList.Item>
<ActionList.Divider />
<ActionList.Item onClick={() => alert('Workflows clicked')}>Copy path</ActionList.Item>
<ActionList.Item onClick={() => alert('Workflows clicked')}>Copy permalink</ActionList.Item>
<ActionList.Item onSelect={() => alert('Workflows clicked')}>Copy path</ActionList.Item>
<ActionList.Item onSelect={() => alert('Workflows clicked')}>Copy permalink</ActionList.Item>
</ActionList.Group>
<ActionList.Divider />
<ActionList.Group selectionVariant="multiple">
Expand All @@ -437,7 +437,7 @@ export const MultipleSections = () => {
<ActionList.Divider />
<ActionList.Group>
<ActionList.GroupHeading>View options</ActionList.GroupHeading>
<ActionList.Item onClick={() => alert('Delete file')} variant="danger">
<ActionList.Item onSelect={() => alert('Delete file')} variant="danger">
Delete file
</ActionList.Item>
</ActionList.Group>
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/ActionMenu/ActionMenu.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function ExampleWithTooltip(): JSX.Element {
return (
<ThemeProvider theme={theme}>
<BaseStyles>
<Tooltip aria-label="Additional context about the menu button" direction="s">
<Tooltip text="Additional context about the menu button" direction="s">
<ActionMenu>
<ActionMenu.Button>Toggle Menu</ActionMenu.Button>
<ActionMenu.Overlay>
Expand Down
10 changes: 5 additions & 5 deletions packages/react/src/NavList/NavList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ function ItemWithSubNav({
aria-expanded={isOpen}
aria-controls={subNavId}
active={!isOpen && containsCurrentItem}
onClick={() => setIsOpen(open => !open)}
onSelect={() => setIsOpen(open => !open)}
style={style}
sx={sxProp}
>
Expand All @@ -193,7 +193,7 @@ function ItemWithSubNav({
aria-expanded={isOpen}
aria-controls={subNavId}
active={!isOpen && containsCurrentItem}
onClick={() => setIsOpen(open => !open)}
onSelect={() => setIsOpen(open => !open)}
style={style}
>
{children}
Expand All @@ -216,7 +216,7 @@ function ItemWithSubNav({
aria-controls={subNavId}
// When the subNav is closed, how should we indicated that the subNav contains the current item?
active={!isOpen && containsCurrentItem}
onClick={() => setIsOpen(open => !open)}
onSelect={() => setIsOpen(open => !open)}
sx={merge<SxProp['sx']>(
{
...getSubnavStyles(depth),
Expand Down Expand Up @@ -491,7 +491,7 @@ export const GroupExpand = React.forwardRef<HTMLButtonElement, NavListGroupExpan
as="button"
aria-expanded="false"
ref={forwardedRef}
onClick={() => {
onSelect={() => {
flushSync(() => {
setCurrentPage(currentPage + 1)
})
Expand All @@ -517,7 +517,7 @@ export const GroupExpand = React.forwardRef<HTMLButtonElement, NavListGroupExpan
as="button"
aria-expanded="false"
ref={forwardedRef}
onClick={() => {
onSelect={() => {
flushSync(() => {
setCurrentPage(currentPage + 1)
})
Expand Down
Loading
Loading