Skip to content

chore: update vitest, add node config and disable screenshots #6159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
253 changes: 153 additions & 100 deletions package-lock.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@primer/stylelint-config": "13.3.0",
"@size-limit/preset-big-lib": "11.2.0",
"@types/jest": "29.5.14",
"@vitest/browser": "^3.1.2",
"@vitest/browser": "^3.2.0",
"eslint": "^9.25.1",
"eslint-import-resolver-typescript": "3.7.0",
"eslint-plugin-clsx": "^0.0.10",
Expand Down Expand Up @@ -89,7 +89,7 @@
"typed-css-modules": "0.9.1",
"typescript": "^5.8.2",
"typescript-eslint": "^8.33.0",
"vitest": "^3.1.2"
"vitest": "^3.2.0"
},
"optionalDependencies": {
"@rollup/rollup-linux-x64-gnu": "^4.41.1"
Expand Down
1 change: 1 addition & 0 deletions packages/react/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ module.exports = {
setupFilesAfterEnv: ['<rootDir>/src/utils/test-matchers.tsx', '<rootDir>/src/utils/test-deprecations.tsx'],
testMatch: ['<rootDir>/**/*.test.[jt]s?(x)', '!**/*.types.test.[jt]s?(x)'],
modulePathIgnorePatterns: [
'<rootDir>/src/__tests__/exports.test.ts',
'<rootDir>/src/ActionBar/',
'<rootDir>/src/ActionList/',
'<rootDir>/src/AnchoredOverlay/',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

exports[`@primer/react should not update exports without a semver change 1`] = `
exports[`@primer/react > should not update exports without a semver change 1`] = `
[
"ActionBar",
"type ActionBarProps",
Expand Down Expand Up @@ -219,7 +219,7 @@ exports[`@primer/react should not update exports without a semver change 1`] = `
]
`;

exports[`@primer/react/deprecated should not update exports without a semver change 1`] = `
exports[`@primer/react/deprecated > should not update exports without a semver change 1`] = `
[
"ActionList",
"type ActionListGroupedListProps",
Expand Down Expand Up @@ -249,7 +249,7 @@ exports[`@primer/react/deprecated should not update exports without a semver cha
]
`;

exports[`@primer/react/experimental should not update exports without a semver change 1`] = `
exports[`@primer/react/experimental > should not update exports without a semver change 1`] = `
[
"ActionBar",
"type ActionBarProps",
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/__tests__/exports.test.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import {existsSync} from 'node:fs'
import fs from 'node:fs/promises'
import path from 'node:path'
import {beforeAll, describe, expect, it} from 'vitest'
// eslint-disable-next-line import/no-namespace
import * as parser from '@babel/parser'
import {traverse} from '@babel/core'
Expand Down
76 changes: 76 additions & 0 deletions packages/react/vitest.config.browser.mts
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
import {defineConfig} from 'vitest/config'
import react from '@vitejs/plugin-react'

export default defineConfig({
plugins: [react()],
define: {
__DEV__: true,
},
test: {
name: '@primer/react',
exclude: [
'**/node_modules/**',
'**/dist/**',
'**/lib-esm/**',
'**/lib/**',
'**/generated/**',
'**/*.figma.tsx',
'**/*.types.test.tsx',
],
include: [
'src/ActionBar/**/*.test.?(c|m)[jt]s?(x)',
'src/ActionList/**/*.test.?(c|m)[jt]s?(x)',
'src/AnchoredOverlay/**/*.test.?(c|m)[jt]s?(x)',
'src/Banner/**/*.test.?(c|m)[jt]s?(x)',
'src/Blankslate/**/*.test.?(c|m)[jt]s?(x)',
'src/BranchName/**/*.test.?(c|m)[jt]s?(x)',
'src/Breadcrumbs/**/*.test.?(c|m)[jt]s?(x)',
'src/ButtonGroup/**/*.test.?(c|m)[jt]s?(x)',
'src/CheckboxGroup/**/*.test.?(c|m)[jt]s?(x)',
'src/CircleBadge/**/*.test.?(c|m)[jt]s?(x)',
'src/CircleOcticon/**/*.test.?(c|m)[jt]s?(x)',
'src/DataTable/**/*.test.?(c|m)[jt]s?(x)',
'src/FeatureFlags/**/*.test.?(c|m)[jt]s?(x)',
'src/NavList/**/*.test.?(c|m)[jt]s?(x)',
'src/ProgressBar/**/*.test.?(c|m)[jt]s?(x)',
'src/Radio/**/*.test.?(c|m)[jt]s?(x)',
'src/RadioGroup/**/*.test.?(c|m)[jt]s?(x)',
'src/RelativeTime/**/*.test.?(c|m)[jt]s?(x)',
'src/ScrollableRegion/**/*.test.?(c|m)[jt]s?(x)',
'src/Select/**/*.test.?(c|m)[jt]s?(x)',
'src/Skeleton/**/*.test.?(c|m)[jt]s?(x)',
'src/Spinner/**/*.test.?(c|m)[jt]s?(x)',
'src/Stack/**/*.test.?(c|m)[jt]s?(x)',
'src/StateLabel/**/*.test.?(c|m)[jt]s?(x)',
'src/SubNav/**/*.test.?(c|m)[jt]s?(x)',
'src/TabNav/**/*.test.?(c|m)[jt]s?(x)',
'src/TextInputWithTokens/**/*.test.?(c|m)[jt]s?(x)',
'src/Textarea/**/*.test.?(c|m)[jt]s?(x)',
'src/Timeline/**/*.test.?(c|m)[jt]s?(x)',
'src/ToggleSwitch/**/*.test.?(c|m)[jt]s?(x)',
'src/Tooltip/**/*.test.?(c|m)[jt]s?(x)',
'src/TooltipV2/**/*.test.?(c|m)[jt]s?(x)',
'src/Truncate/**/*.test.?(c|m)[jt]s?(x)',
'src/UnderlineNav/**/*.test.?(c|m)[jt]s?(x)',
'src/hooks/**/*.test.?(c|m)[jt]s?(x)',
'src/live-region/**/*.test.?(c|m)[jt]s?(x)',
'src/utils/__tests__/invariant.test.?(c|m)[jt]s?(x)',
'src/utils/__tests__/warning.test.?(c|m)[jt]s?(x)',
],
setupFiles: ['config/vitest/setup.ts'],
css: {
include: [/.+/],
},
browser: {
provider: 'playwright',
enabled: true,
headless: process.env.DEBUG_BROWSER_TESTS === 'true' ? false : true,
instances: [
{
browser: 'chromium',
},
],
screenshotFailures: false,
},
},
})
73 changes: 4 additions & 69 deletions packages/react/vitest.config.mts
Original file line number Diff line number Diff line change
@@ -1,74 +1,9 @@
import {defineConfig} from 'vitest/config'
import react from '@vitejs/plugin-react'

export default defineConfig({
plugins: [react()],
define: {
__DEV__: true,
},
test: {
exclude: [
'**/node_modules/**',
'**/dist/**',
'**/lib-esm/**',
'**/lib/**',
'**/generated/**',
'**/*.figma.tsx',
'**/*.types.test.tsx',
],
include: [
'src/ActionBar/**/*.test.?(c|m)[jt]s?(x)',
'src/ActionList/**/*.test.?(c|m)[jt]s?(x)',
'src/AnchoredOverlay/**/*.test.?(c|m)[jt]s?(x)',
'src/Banner/**/*.test.?(c|m)[jt]s?(x)',
'src/Blankslate/**/*.test.?(c|m)[jt]s?(x)',
'src/BranchName/**/*.test.?(c|m)[jt]s?(x)',
'src/Breadcrumbs/**/*.test.?(c|m)[jt]s?(x)',
'src/ButtonGroup/**/*.test.?(c|m)[jt]s?(x)',
'src/CheckboxGroup/**/*.test.?(c|m)[jt]s?(x)',
'src/CircleBadge/**/*.test.?(c|m)[jt]s?(x)',
'src/CircleOcticon/**/*.test.?(c|m)[jt]s?(x)',
'src/DataTable/**/*.test.?(c|m)[jt]s?(x)',
'src/FeatureFlags/**/*.test.?(c|m)[jt]s?(x)',
'src/NavList/**/*.test.?(c|m)[jt]s?(x)',
'src/ProgressBar/**/*.test.?(c|m)[jt]s?(x)',
'src/Radio/**/*.test.?(c|m)[jt]s?(x)',
'src/RadioGroup/**/*.test.?(c|m)[jt]s?(x)',
'src/RelativeTime/**/*.test.?(c|m)[jt]s?(x)',
'src/ScrollableRegion/**/*.test.?(c|m)[jt]s?(x)',
'src/Select/**/*.test.?(c|m)[jt]s?(x)',
'src/Skeleton/**/*.test.?(c|m)[jt]s?(x)',
'src/Spinner/**/*.test.?(c|m)[jt]s?(x)',
'src/Stack/**/*.test.?(c|m)[jt]s?(x)',
'src/StateLabel/**/*.test.?(c|m)[jt]s?(x)',
'src/SubNav/**/*.test.?(c|m)[jt]s?(x)',
'src/TabNav/**/*.test.?(c|m)[jt]s?(x)',
'src/TextInputWithTokens/**/*.test.?(c|m)[jt]s?(x)',
'src/Textarea/**/*.test.?(c|m)[jt]s?(x)',
'src/Timeline/**/*.test.?(c|m)[jt]s?(x)',
'src/ToggleSwitch/**/*.test.?(c|m)[jt]s?(x)',
'src/Tooltip/**/*.test.?(c|m)[jt]s?(x)',
'src/TooltipV2/**/*.test.?(c|m)[jt]s?(x)',
'src/Truncate/**/*.test.?(c|m)[jt]s?(x)',
'src/UnderlineNav/**/*.test.?(c|m)[jt]s?(x)',
'src/hooks/**/*.test.?(c|m)[jt]s?(x)',
'src/live-region/**/*.test.?(c|m)[jt]s?(x)',
'src/utils/__tests__/invariant.test.?(c|m)[jt]s?(x)',
'src/utils/__tests__/warning.test.?(c|m)[jt]s?(x)',
],
setupFiles: ['config/vitest/setup.ts'],
css: {
include: [/.+/],
},
browser: {
provider: 'playwright',
enabled: true,
headless: process.env.DEBUG_BROWSER_TESTS === 'true' ? false : true,
instances: [
{
browser: 'chromium',
},
],
},
name: '@primer/react (node)',
include: ['src/__tests__/exports.test.ts'],
environment: 'node',
},
})
})
2 changes: 1 addition & 1 deletion vitest.config.mts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ import {defineConfig} from 'vitest/config'

export default defineConfig({
test: {
workspace: ['packages/*/vitest.config.ts', 'packages/*/vitest.config.mts'],
projects: ['packages/*/vitest.config.ts', 'packages/*/vitest.config.mts', 'packages/*/vitest.config.browser.mts'],
},
})
Loading