-
Notifications
You must be signed in to change notification settings - Fork 614
fix Banner spacing #6190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Banner spacing #6190
Conversation
🦋 Changeset detectedLatest commit: 5f281fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as resolved.
This comment was marked as resolved.
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This patch fixes the vertical alignment of the Banner component and corrects a typo in the story description.
- Aligns banner content centrally instead of at the start
- Fixes typo in the Playground description text
- Adds a changeset to trigger a patch release
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
File | Description |
---|---|
Banner.stories.tsx | Corrected typo in the description arg (en able → enable ) |
Banner.module.css | Changed align-items from start to center in container |
.changeset/big-hairs-agree.md | Added changeset entry for a patch release |
…tions are present, so that the button and x will be aligned when seen together, but there will will be no x position change if there is an x with no BannerActions
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
Documenting some context for the newer code changes based on slack DMs with The change that addressed this original issue (before/after): was causing this view to look wonky because the So I have conditionally applied a matching style to the dismiss but the Margins adjusted with buttons vs. default: |
Closes https://github.com/github/primer/issues/3720
Changelog
Changed
Styling update addressing banner spacing issues--see vertical alignment on single line banner below (before / after):
Rollout strategy
Testing & Reviewing
I used the following Playground settings to see this view where the issue was occurring (viewable here):
Merge checklist