Remove support for sx from BranchName component
#6625
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 15c149e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
integration-tests: recommended
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Update BranchName component to no longer support sx, add sx wrapper to @primer/styled-react
size-limit report 📦
|
llastflowers
changed the title
sx from the BranchName componentsx from BranchName component
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/397512 |
github-actions
bot
added
integration-tests: failing
|
🔴 golden-jobs completed with status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/github/primer/issues/5730
Still need to separately update github-ui components to use @primer/styled-react (sx: 3)
Changelog
Removed
sxfrom the BranchName componentRollout strategy
We are using the
@primer/styled-reactcomponent to mitigate removingsxusage. We will make sure usage is updated upstream before merging.Merge checklist