-
Notifications
You must be signed in to change notification settings - Fork 625
Remove sx
prop support from ToggleSwitch
#6627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 81b9da0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/397774 |
🔴 golden-jobs completed with status |
Migrates the
ToggleSwitch
component away fromBox
components andsx
prop support to use CSS modules, closes #4826What Changed
Removed
Box
wrapper andsx
prop support from the main ToggleSwitch componentReplaced
sx
prop styling with CSS modules and data attributes for state-based stylingAdded ToggleSwitch to the
styled-react
package for repos still usingsx
propsNote:
SwitchButton
andToggleKnob
still use styled-components (styled.button
andstyled.div
) and will be migrated in a future iterationRollout strategy