primer/react: Remove StyledComponentsThemeProvider from ThemeProvider #7001
+803
−210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ef45ca0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
siddharthkp
changed the title
siddharthkp
changed the title
github-actions
bot
requested a deployment
to
storybook-preview-7001
github-actions
bot
requested a deployment
to
storybook-preview-7001
github-actions
bot
requested a deployment
to
storybook-preview-7001
|
(updating VRT snapshots in #7027 for acurate diff) |
examples/nextjs/src/app/layout.tsx
Outdated
| <BaseStyles>{children}</BaseStyles> | ||
| </ThemeProvider> | ||
| </StyledComponentsRegistry> | ||
| <FeatureFlags flags={{primer_react_use_styled_react_theming: true}}> |
There was a problem hiding this comment.
do we need this since we remove the FF? 👀
There was a problem hiding this comment.
not anymore! based this branch of main, that's why I had the feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollout strategy
Testing & Reviewing
Merge checklist