Skip to content

Trying to add live editor #7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Trying to add live editor #7002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
447a343
trying to add live editoer
lukasoppermann Oct 14, 2025
cd7308b
added live code editor to Avatar
lukasoppermann Oct 14, 2025
c413237
remove comment
lukasoppermann Oct 14, 2025
8138114
update Playground story
lukasoppermann Oct 14, 2025
ba0ea18
format
francinelucca Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
"rimraf": "5.0.5",
"size-limit": "11.2.0",
"storybook": "^9.1.8",
"storybook-addon-code-editor": "^5.0.0",
"stylelint": "16.20.0",
"turbo": "^2.5.5",
"typescript": "^5.9.2",
Expand Down
3 changes: 3 additions & 0 deletions packages/react/.storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@ import path from 'node:path'
import react from '@vitejs/plugin-react'
import postcssPresetPrimer from 'postcss-preset-primer'
import type {StorybookConfig} from '@storybook/react-vite'
import {getCodeEditorStaticDirs} from 'storybook-addon-code-editor/getStaticDirs'
import {isSupported} from '../script/react-compiler.mjs'

const require = createRequire(import.meta.url)

const {DEPLOY_ENV = 'development'} = process.env

const config: StorybookConfig = {
staticDirs: [...getCodeEditorStaticDirs(__filename)],
stories:
DEPLOY_ENV === 'development'
? ['../src/**/*.mdx', '../src/**/*.stories.@(js|jsx|ts|tsx)']
Expand All @@ -20,6 +22,7 @@ const config: StorybookConfig = {
getAbsolutePath('@storybook/addon-a11y'),
getAbsolutePath('@storybook/addon-links'),
getAbsolutePath('@storybook/addon-docs'),
'storybook-addon-code-editor',
],

framework: {
Expand Down
36 changes: 25 additions & 11 deletions packages/react/src/Avatar/Avatar.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import type {Meta, StoryFn} from '@storybook/react-vite'
import type {AvatarProps} from './Avatar'
import Avatar, {DEFAULT_AVATAR_SIZE} from './Avatar'
import {parseSizeFromArgs} from './storyHelpers'
import {makeLiveEditStory} from 'storybook-addon-code-editor'
import * as PrimerReactLibrary from '../index'

export default {
title: 'Components/Avatar',
Expand All @@ -15,18 +17,16 @@ type Args = {
sizeAtWide?: number
} & Omit<AvatarProps, 'size'>

export const Default = () => <Avatar src="https://avatars.githubusercontent.com/u/7143434?v=4" />
export const Default = {}

export const Playground: StoryFn<Args> = args => {
return (
<Avatar
size={parseSizeFromArgs(args)}
square={args.square}
src="https://avatars.githubusercontent.com/u/7143434?v=4"
alt="mona"
/>
)
}
makeLiveEditStory(Default, {
availableImports: {'@primer/react': PrimerReactLibrary},
code: `import { Avatar } from '@primer/react';

export default () => <Avatar src="https://avatars.githubusercontent.com/u/7143434?v=4" />`,
})

export const Playground = {}

Playground.args = {
size: DEFAULT_AVATAR_SIZE,
Expand Down Expand Up @@ -63,3 +63,17 @@ Playground.argTypes = {
},
},
}

makeLiveEditStory(Playground, {
availableImports: {'@primer/react': PrimerReactLibrary},
code: `import { Avatar } from '@primer/react';

export default (args) => (
<Avatar
size={args.size || 24}
square={args.square}
src="https://avatars.githubusercontent.com/u/7143434?v=4"
alt="mona"
/>
);`,
})
Loading