Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build artifact and release assets #13

Merged

Conversation

henning-gerhardt
Copy link
Contributor

@henning-gerhardt henning-gerhardt commented Nov 30, 2024

This pull request may superseed #12.

Instead of running two workflows and two possible different builds the created files from the CI workflow are used to create even the release builds assets. Benefit is that every build now create all artifacts assets for every operation system so even without a release every one on every supported operation system can try the most recent version out without the need to build mfakto itself.

I discovered too how to build the artifact and release assert on windows-msvc. This can even be pack ported to #12 if two independent build workflows should be used.

I could only test the created Linux based assets in a successful way, so Windows and MacOS should be tested who can access them.

Edit:

@henning-gerhardt
Copy link
Contributor Author

With the latest change I created a new test tag https://github.com/henning-gerhardt/mfakto/releases/tag/v0.0.3.

The build artifacts are available under https://github.com/primesearch/mfakto/actions/runs/12095551380 for the latest changes of this pull request. After this change is merged they are available under https://github.com/primesearch/mfakto/actions -> Commit name -> Artifacts

@jcoxdco
Copy link

jcoxdco commented Dec 7, 2024

I pulled down mfakto-v0.0.2-windows-msvc. Self tests passed. Windows 11, RDNA3 7700 XT.
I didn't finish the TF of that exponent. I can if you think it is needed.

image

@henning-gerhardt
Copy link
Contributor Author

Thank you for testing this build, jcoxdco. I'm hoping that the builds are helping everyone who want to use mfakto.

@henning-gerhardt henning-gerhardt force-pushed the build_asserts_on_ci_and_release branch from 545f543 to c019bf5 Compare February 5, 2025 06:59
@henning-gerhardt henning-gerhardt force-pushed the build_asserts_on_ci_and_release branch from c019bf5 to 17718f1 Compare February 5, 2025 07:02
@henning-gerhardt
Copy link
Contributor Author

I rebased this pull request to include the latest changes regarding the Makefile changes and smashed all MacOS related commits into one commit.

@proski proski merged commit 24e4be1 into primesearch:master Feb 5, 2025
5 checks passed
@henning-gerhardt henning-gerhardt deleted the build_asserts_on_ci_and_release branch February 5, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants