Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enigma.Dockerfile #828

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Reckon-11
Copy link

@Reckon-11 Reckon-11 commented Oct 27, 2024

Reference Issues/PRs

Your Dockerfile is already set up to handle various dependencies, especially for CTF and reverse engineering tasks. Here are some optimizations and improvements for this setup:

What does this implement/fix? Explain your changes.

Layer Minimization: Combine RUN instructions where possible to reduce image layers.
Dependency Management: Clean up apt cache after each installation step to keep the image size manageable.
Download Management: Use wget with -q (quiet) for less verbose output.
Consistent Environment Variables: Group common configurations (like ENV PATH) together.

Your Dockerfile is already set up to handle various dependencies, especially for CTF and reverse engineering tasks. Here are some optimizations and improvements for this setup:

Layer Minimization: Combine RUN instructions where possible to reduce image layers.
Dependency Management: Clean up apt cache after each installation step to keep the image size manageable.
Download Management: Use wget with -q (quiet) for less verbose output.
Consistent Environment Variables: Group common configurations (like ENV PATH) together.
@klieret
Copy link
Member

klieret commented Oct 28, 2024

Hi @Reckon-11 . Have you checked that the dockerfile still builds?

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.20%. Comparing base (dd77a99) to head (60e6ff7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #828   +/-   ##
=======================================
  Coverage   75.20%   75.20%           
=======================================
  Files          31       31           
  Lines        4605     4605           
=======================================
  Hits         3463     3463           
  Misses       1142     1142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Reckon-11
Copy link
Author

Assuming all external resources are available and paths are correct, this Dockerfile should build successfully.

@klieret
Copy link
Member

klieret commented Oct 28, 2024

Please test that it still builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants