Resolve fully-uppercase builtin identifiers #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users try to use uppercase function names like LOG as they are used to Excel functions, which don't work in fend. Resolve fully-uppercase builtin identifiers if they are not parsed as units. This ensures that if, for example, "I" becomes a unit in the future, it will be resolved as the unit - not the imaginary number.
mlcui-corp
force-pushed
the
push-wuqtusywnyvz
branch
from
5e2e2f5
to
3cb990d
Compare
mlcui-corp
commented
Jun 21, 2024
|
Thanks for the PR, and sorry for the delay in reviewing this. I'll try and take a look at this and your other pull request in the next couple days. |
|
Thanks! |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 30, 2024
These have been fixed upstream: - Percentage: printfn/fend#301 - Uppercase identifiers: printfn/fend#300 Fixed: b:342481033, b:345302335 Change-Id: I6a6a21007cd99dd46ed2b6537afbeeb7aa19e081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5740190 Commit-Queue: Michael Cui <[email protected]> Auto-Submit: Michael Cui <[email protected]> Reviewed-by: Darren Shen <[email protected]> Commit-Queue: Darren Shen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1334642}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users try to use uppercase function names like LOG as they are used to Excel functions, which don't work in fend.
Resolve fully-uppercase builtin identifiers if they are not parsed as units. This ensures that if, for example, "I" becomes a unit in the future, it will be resolved as the unit - not the imaginary number.