Adnan/printivity taxjar master merge #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaxJar requires certified extensions to include an API version in the header of each request. This extensions wraps the official TaxJar Ruby Gem with another API client, so we make sure the version gets set in when our wrapper class is constructed. Co-authored-by: Noah Silvera <[email protected]>
…-in-request-headers
When setting up this project and running specs, it's important to make sure all versions are compatible. As such we make a note in the README and provide the versions from the CI Co-authored-by: Noah Silvera <[email protected]>
…ation-to-readme Add information to README about versions in setup
Upcoming work to get this extension officially certified with Taxjar will require the addition of UI components into the solidus backend. Creating a rails engine for the new rails components of this extension is a prerequisite to any UI work. Co-authored-by: Nick Van Doorn <[email protected]> Co-authored-by: Adam Mueller <[email protected]>
Add a note about the addition of the rails engine.
This template just asks contributors to state the goal of the PR, and provide a testing and merging checklist.
To meet Taxjar's certification requirements, we need to supply a 'plugin' name in each API request header. As such we add this header where the API version header is supplied. Co-authored-by: Noah Silvera <[email protected]>
…s-engine Add taxjar rails engine
…t-template Add pull request template
…-headers Put plugin name in API request headers
Once we add an install generator with migrations, having an engine name with a dash in it will cause the migration generation to fail, as migrations will be created with the engine name in it, and dashes are not allowed. Co-authored-by: Nick Van Doorn <[email protected]>
Update the engine name
In order for the Zeitwerk loader to properly identity our classes from the file names, we should remove camel casing from this name that isn't consistent with underscores in the file name itself. Co-authored-by: Nick Van Doorn <[email protected]>
This done so Zeitwerk can correctly can correctly load the class from the filename. Co-authored-by: Nick Van Doorn <[email protected]>
Previous changes allow this gem to support zeitwerk loading, and by extension, rails 6. We should add a test case for this in the CI. Co-authored-by: Nick Van Doorn <[email protected]>
Improve the installation instructions and remove outdated messaging
Add information around the breaking changes added and upgrade instructions for 0.17.X to 0.18.X Co-authored-by: Nick Van Doorn <[email protected]>
…k-loading Support zeitwerk loading (0.18.0)
This change adds a failing spec which exposes a typo in our API params helper method. In the next change we'll fix the issue and un-pend the spec.
This change fixes a typo in the params helper for addresses without a `state` association. This was a previously untested behaviour so we never caught this. This change also marks the failing test as no longer pending.
This links to the PR where we fixed the issue from the changelog file, so we can know what is in the next release of the gem.
Fix typo in address parameter helper
This was not used and should be removed. Co-authored-by: Noah Silvera <[email protected]>
In SuperGoodSoft#34, we modified `.default_taxjar_client` to include the API version, and then the name of the plugin, but we also introduced a critical bug. `Taxjar::Client#set_api_config` returns a hash and not the TaxJar client, so it is not safe to chain the method call. As such, we add a spec to cover this case and patch the class method. Co-authored-by: Noah Silvera <[email protected]>
A recent release contained a critical regression, so we're adding an extra pre merge step to prevent this from happening. Co-authored-by: Noah Silvera <[email protected]>
Co-authored-by: Noah Silvera <[email protected]>
Fix critical bug in API class
Now that we're syncing transactions in batches, we should allow users to inspect an individual batch and see the status of specific orders. Co-authored-by: Chris Todorov <[email protected]> Co-authored-by: Noah Silvera <[email protected]>
Now that we a user interface to show the status of a transaction sync batch, we no longer need a flash message or a template for the `backfill_transactions` action. Co-authored-by: Chris Todorov <[email protected]> Co-authored-by: Noah Silvera <[email protected]>
Co-authored-by: Chris Todorov <[email protected]>
# Conflicts: # CHANGELOG.md # README.md # lib/super_good/solidus_taxjar.rb # lib/super_good/solidus_taxjar/api.rb # lib/super_good/solidus_taxjar/api_params.rb # lib/super_good/solidus_taxjar/calculator_helper.rb # lib/super_good/solidus_taxjar/tax_calculator.rb # lib/super_good/solidus_taxjar/version.rb # spec/super_good/solidus_taxjar/api_params_spec.rb # spec/super_good/solidus_taxjar/api_spec.rb # spec/super_good/solidus_taxjar_spec.rb # super_good_solidus_taxjar.gemspec
AdnanTheExcellent
changed the base branch from
master
to
adnan/taxjar-customers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge latest origin code and copy over taxjar code from printivity into this repo
launch notes: set DB variable in taxjar configuration to enable sending transactions