Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): proxy for GA #1157

Merged
merged 5 commits into from
Jul 27, 2020
Merged

chore(website): proxy for GA #1157

merged 5 commits into from
Jul 27, 2020

Conversation

nilubava
Copy link
Contributor

@nilubava nilubava commented Jul 1, 2020

No description provided.

@nilubava nilubava changed the title fix: proxy for GA fix(website): proxy for GA Jul 1, 2020
@2color
Copy link

2color commented Jul 1, 2020

LGTM

@nilubava nilubava requested review from janpio and mhwelander July 1, 2020 10:39
@jasonkuhrt jasonkuhrt changed the title fix(website): proxy for GA chore(website): proxy for GA Jul 1, 2020
@jasonkuhrt
Copy link
Member

jasonkuhrt commented Jul 1, 2020

Until we improve our CI setup we need to keep these as chore type commits to avoid publishing new nexus packages.

@jasonkuhrt jasonkuhrt merged commit 4365a94 into master Jul 27, 2020
@jasonkuhrt jasonkuhrt deleted the ga-proxy branch July 27, 2020 23:11
@janpio
Copy link
Contributor

janpio commented Jul 28, 2020

Is there an issue for this improvement @jasonkuhrt?

@jasonkuhrt
Copy link
Member

@janpio
Copy link
Contributor

janpio commented Jul 28, 2020

Ah, I would have expected an exclude of the website folder.

@jasonkuhrt
Copy link
Member

That would be better, any tips?

@janpio
Copy link
Contributor

janpio commented Jul 29, 2020

Without looking into your CI config deeper: Maybe the last example from https://github.blog/changelog/2019-09-30-github-actions-event-filtering-updates/ could help to just not trigger builds on website only changes.

@jasonkuhrt
Copy link
Member

Thanks will take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants