Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Convert the RegExp to a string #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andyeskridge
Copy link

By converting the RegExp to a string webpack stops complaining. I've done some quick testing and it seem that everything is still working, but I would love some other eyes on this.

Because webpack converts globs to RegExp it seems that it executes this RegExp that is just a sting. (https://webpack.js.org/configuration/watch/#watchoptionsignored)

This closes #31

@andyeskridge andyeskridge changed the title Convert the RegExp to a string Fix: Convert the RegExp to a string Jun 30, 2021
@jaredpalmer
Copy link

This worked for me

@deadcoder0904
Copy link

deadcoder0904 commented Jul 19, 2021

@williamluke4 wanna merge & release this one?

Edit

Till then I used commit hash in my package.json:

"next-prisma-plugin": "prisma-labs/next-prisma-plugin#a3c6e044a9b44bfbe6a799e2e2377a15280b1569"

I also tried installing the package like:

$ npm i andyeskridge/next-prisma-plugin#patch-1

However, it didn't help. It gives me:

Error: Cannot find module '\node_modules\next-prisma-plugin\dist\index.js'. Please verify that the package.json has a valid "main" entry

@andyeskridge
Copy link
Author

@williamluke4 wanna merge & release this one?

Edit

Till then I used commit hash in my package.json:

"next-prisma-plugin": "prisma-labs/next-prisma-plugin#a3c6e044a9b44bfbe6a799e2e2377a15280b1569"

I also tried installing the package like:

$ npm i andyeskridge/next-prisma-plugin#patch-1

However, it didn't help. It gives me:

Error: Cannot find module '\node_modules\next-prisma-plugin\dist\index.js'. Please verify that the package.json has a valid "main" entry

Yeah the plugin requires a build, while I was waiting for this to be unblocked I published a npm package to use in the meantime. https://www.npmjs.com/package/next-prisma-plugin-webpack5

@deadcoder0904
Copy link

Thanks, Andy, was just gonna ask about it now 😂

@DaniGuardiola
Copy link

DaniGuardiola commented Oct 30, 2021

Hi there :) any plans to merge this and create a release? Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack 5 / Next.js 10.0.2 support
4 participants