Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JOINs piece to relational databases section #470

Merged
merged 29 commits into from
May 6, 2024
Merged

Conversation

grpatel
Copy link
Contributor

@grpatel grpatel commented Apr 25, 2024

No description provided.

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dataguide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 9:06pm

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 16.5%, saving 143.38 KB.

Filename Before After Improvement Visual comparison
content/dataguide-images/types/relational/what-are-joins/full-join.png 14.34 KB 10.34 KB -27.9% View diff
content/dataguide-images/types/relational/what-are-joins/header-image.png 183.91 KB 137.14 KB -25.4% View diff
content/dataguide-images/types/relational/what-are-joins/inner-join.png 14.27 KB 10.57 KB -25.9% View diff
content/dataguide-images/types/relational/what-are-joins/left-join.png 14.27 KB 10.53 KB -26.2% View diff
content/dataguide-images/types/relational/what-are-joins/relationship-between-tables.png 325.13 KB 283.68 KB -12.7% View diff
content/dataguide-images/types/relational/what-are-joins/right-join.png 14.85 KB 10.81 KB -27.2% View diff
content/dataguide-images/types/relational/what-are-joins/table-properties.png 302.92 KB 263.24 KB -13.1% View diff

237 images did not require optimisation.

content/03-types/02-relational/07-what-are-joins.mdx Outdated Show resolved Hide resolved
content/03-types/02-relational/07-what-are-joins.mdx Outdated Show resolved Hide resolved
content/03-types/02-relational/07-what-are-joins.mdx Outdated Show resolved Hide resolved
content/03-types/02-relational/07-what-are-joins.mdx Outdated Show resolved Hide resolved

## Introduction

![JOINs header image](../../dataguide-images/types/relational/what-are-joins/header-image.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the header image from the page. In Data Guide, we only use it as meta image.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally think it'll be a good addition! I noticed these pages have a header image: Database migrations and Expand and Contract.

But if we really want to remove, I totally can 🙂

Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great article, Grishma! really nice explanations and visuals of the different JOIN types. I've left a couple of comments/suggestions that I think would make the article even nicer to read and better to understand in some areas. overall fantastic work though 👏

content/03-types/02-relational/07-what-are-joins.mdx Outdated Show resolved Hide resolved
content/03-types/02-relational/07-what-are-joins.mdx Outdated Show resolved Hide resolved
content/03-types/02-relational/07-what-are-joins.mdx Outdated Show resolved Hide resolved
content/03-types/02-relational/07-what-are-joins.mdx Outdated Show resolved Hide resolved
content/03-types/02-relational/07-what-are-joins.mdx Outdated Show resolved Hide resolved
content/03-types/02-relational/07-what-are-joins.mdx Outdated Show resolved Hide resolved
content/03-types/02-relational/07-what-are-joins.mdx Outdated Show resolved Hide resolved
content/03-types/02-relational/07-what-are-joins.mdx Outdated Show resolved Hide resolved
To address this duplication, we can pair `LATERAL JOIN`s with JSON aggregation. JSON aggregation helps avoid duplication by consolidating multiple related records into a single field as a JSON array, while `LATERAL JOIN`s help improve readability and can optimize performance.

Here is an example of what the result set would look like using `LATERAL JOIN`s with JSON aggregation:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to see the query that led to this result set!

content/03-types/02-relational/07-what-are-joins.mdx Outdated Show resolved Hide resolved
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great article, Grishma! really nice explanations and visuals of the different JOIN types. I've left a couple of comments/suggestions that I think would make the article even nicer to read and better to understand in some areas. overall fantastic work though 👏

@grpatel
Copy link
Contributor Author

grpatel commented May 3, 2024

Hi @nikolasburk, I implemented the changes last Friday EOD - let me know if you think it's ready to merge. Thanks!

@nikolasburk nikolasburk self-requested a review May 6, 2024 10:33
Copy link
Member

@nikolasburk nikolasburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes, Grishma!! this looks really great now 🎉 (hope you're enjoying your time off 😄 )

@nikolasburk nikolasburk merged commit 23c2469 into main May 6, 2024
4 checks passed
@nikolasburk nikolasburk deleted the dataguide branch May 6, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants