Fix driver adapters tests after migration of driver adapters to prisma #4398
Conversation
miguelff
requested review from
jkomyno and
Druue
and removed request for
a team
CodSpeed Performance ReportMerging #4398 will not alter performanceComparing Summary
|
|
|
||
| build-driver-adapters: ensure-prisma-present | ||
| @echo "Building driver adapters..." | ||
| @cd ../prisma && pnpm --filter "*adapter*" i && pnpm --filter "*adapter*" build | ||
| @cd ../prisma && pnpm --filter "*adapter*" i |
There was a problem hiding this comment.
@millsp I observed that if I don't install the deps from prisma, I get an error if running pnpm build from prisma-engines/query-engine/driver-adapters. Why can this be, given that all the projects that I'm trying to build are part of the workspace?
There was a problem hiding this comment.
I guess it is because they are still two different workspaces (since they have two different workspace files), so pnpm will not recursively install once it exits on the other workspace.
| "scripts": { | ||
| "build": "pnpm -r run build", | ||
| "lint": "pnpm -r run lint", | ||
| "clean": "git clean -nXd -e !query-engine/driver-adapters" |
There was a problem hiding this comment.
Is this clean command still relevant?
There was a problem hiding this comment.
It is, I expect to use it from time to time, yes.
|
Is |
|
Similar question for Schema Engine tests, Vitess 8 and MariaDB on Windows. Are these just flakey, or did the PR somehoe break them? |
Seem flakey
Still unknown, failed consistenly, I attempt a retry just before you commented. I'm checking. |
| - '../../../prisma/packages/adapter-libsql' | ||
| - '../../../prisma/packages/adapter-neon' | ||
| - '../../../prisma/packages/adapter-pg' | ||
| - '../../../prisma/packages/adapter-planetscale' | ||
| - '../../../prisma/packages/driver-adapter-utils' | ||
| - '../../../prisma/packages/debug' |
There was a problem hiding this comment.
So you don't need to add it in the future
| - '../../../prisma/packages/adapter-libsql' | |
| - '../../../prisma/packages/adapter-neon' | |
| - '../../../prisma/packages/adapter-pg' | |
| - '../../../prisma/packages/adapter-planetscale' | |
| - '../../../prisma/packages/driver-adapter-utils' | |
| - '../../../prisma/packages/debug' | |
| - '../../../prisma/packages/*' |
There was a problem hiding this comment.
Wouldn't this require to build all the packages in the prisma monorepo each time I rebuild driver adapters?
There was a problem hiding this comment.
I would assume that pnpm would only install the deps that you are actually using, the best is to give it a try. Looks good either way.
otherwise @esbuild-register is not found despite being defined as a devDependency within driver adapters @millsp
compiles driver adapters against prisma/prisma#21642