Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech(fmt): extract LSPContext struct #4924

Merged
merged 1 commit into from
Jun 19, 2024
Merged

tech(fmt): extract LSPContext struct #4924

merged 1 commit into from
Jun 19, 2024

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Jun 17, 2024

extracting this change out from
#4923

@Druue Druue added the PR: Improvement A PR that improves existing functionality label Jun 17, 2024
@Druue Druue added this to the 5.16.0 milestone Jun 17, 2024
@Druue Druue self-assigned this Jun 17, 2024
@Druue Druue requested a review from a team as a code owner June 17, 2024 17:02
@Druue Druue requested review from Weakky and removed request for a team June 17, 2024 17:02
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4924 will not alter performance

Comparing tech/lsp-context (d8173e8) with main (05b7e05)

Summary

✅ 11 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2024 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.043MiB 2.043MiB 0.000B
Postgres (gzip) 814.450KiB 814.448KiB 2.000B
Mysql 2.013MiB 2.013MiB 0.000B
Mysql (gzip) 801.128KiB 801.128KiB 0.000B
Sqlite 1.914MiB 1.914MiB 0.000B
Sqlite (gzip) 763.379KiB 763.379KiB 0.000B

@Druue Druue requested a review from SevInf June 18, 2024 13:20
SevInf
SevInf approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@SevInf SevInf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refactor/cleanup

@Druue Druue merged commit 5e01b93 into main Jun 19, 2024
207 checks passed
@Druue Druue deleted the tech/lsp-context branch June 19, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevInf SevInf SevInf approved these changes

@Weakky Weakky Awaiting requested review from Weakky Weakky is a code owner automatically assigned from prisma/orm-rust

Assignees

@Druue Druue

Labels
PR: Improvement A PR that improves existing functionality
Projects
None yet
Milestone
5.16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Druue @SevInf