chore(ci): migrate engine size dashboard to pure bash and GH Actions #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
force-pushed
the
fix-publish-engines-size-v2
branch
from
825850b to
c06dd38
Compare
CodSpeed Performance ReportMerging #5095 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
Due to the lack of Nix buy-in from the team and with most of Nix users leaving, and given the increased overhead of keeping multiple separate build systems and workflows in sync after the introduction of the WebAssembly tooling and difficulties in making changes in Nix code for team members who don't use it, it was previously decided to decrease our reliance on Nix and stop using it on CI, leaving it as optional and only for local development, which mostly happened [in February](#4713). However, the engines size dashboard was still powered by Nix because we ran out of the allocated time for the tech debt task. After the Nix flake was updated last time, the workflow was broken because `wasm-bindgen-cli` in the flake was at 0.2.95 while we are currently pinned to 0.2.93 and are blocked from upgrading to a newer version at the moment. Rather than pinning `wasm-bindgen-cli` to 0.2.93 in the flake by taking it from a different nixpkgs commit, it's a good opportunity to start using the same infrastructure we use for other GitHub Actions jobs instead. With that, and given the fact that our workflows and build scripts are heavily dependent on rustup and we even used rustup within the dev shell instead of the toolchain from `rust-overlay`, there's not much benefit for the local dev shell for Nix users to be a flake, a classic `shell.nix` is more appropriate: pinning the state of the environment in `flake.lock` is no longer useful and only gets in the way. As an added bonus, classic Nix doesn't require copying the sources to the store, which makes the shell startup a bit faster. Fixes: prisma/team-orm#1444 Closes: #5072
aqrln
force-pushed
the
fix-publish-engines-size-v2
branch
from
c06dd38 to
b5afa14
Compare
jacek-prisma
approved these changes
Dec 19, 2024
jkomyno
approved these changes
Dec 19, 2024
|
Workflow tested here: https://github.com/prisma/prisma-engines/actions/runs/12414044363/job/34657269181 |
|
And you can see the new entries here: https://prisma.github.io/prisma-engines/engines-size/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the lack of Nix buy-in from the team and with most of Nix users leaving, and given the increased overhead of keeping multiple separate build systems and workflows in sync after the introduction of the WebAssembly tooling and difficulties in making changes in Nix code for team members who don't use it, it was previously decided to decrease our reliance on Nix and stop using it on CI, leaving it as optional and only for local development, which mostly happened in February. However, the engines size dashboard was still powered by Nix because we ran out of the allocated time for the tech debt task.
After the Nix flake was updated last time, the workflow was broken because
wasm-bindgen-cliin the flake was at 0.2.95 while we are currently pinned to 0.2.93 and are blocked from upgrading to a newer version at the moment. Rather than pinningwasm-bindgen-clito 0.2.93 in the flake by taking it from a different nixpkgs commit, it's a good opportunity to start using the same infrastructure we use for other GitHub Actions jobs instead.With that, and given the fact that our workflows and build scripts are heavily dependent on rustup and we even used rustup within the dev shell instead of the toolchain from
rust-overlay, there's not much benefit for the local dev shell for Nix users to be a flake, a classicshell.nixis more appropriate: pinning the state of the environment inflake.lockis no longer useful and only gets in the way. As an added bonus, classic Nix doesn't require copying the sources to the store, which makes the shell startup a bit faster.Fixes: https://github.com/prisma/team-orm/issues/1444
Closes: #5072