Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(driver-adapters): refactor query-engine test executor #5100

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Dec 29, 2024

This is a refactoring PR in preparation for ORM-460:

  • I've renamed testd into testd-qe, to indicate that the existing (test) playground is for query-engine only
  • I've moved some utilities and setup steps that will be useful for schema-engine-wasm and test-se out of the main executor/src/testd.ts file.
  • I've formatted the executor TS files uniformly. We don't need to bother with linting setups here.

This PR can be merged in main right away, without waiting for schema-engine-wasm to be ready.

Additionally, this PR closes:


Note: when viewing the diff, hide whitespace changes.

@jkomyno jkomyno self-assigned this Dec 29, 2024
@jkomyno jkomyno requested a review from a team as a code owner December 29, 2024 17:56
@jkomyno jkomyno requested review from wmadden and removed request for a team December 29, 2024 17:56
@jkomyno jkomyno added this to the 6.2.0 milestone Dec 29, 2024
Copy link
Contributor

github-actions bot commented Dec 29, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.086MiB 2.084MiB 1.910KiB
Postgres (gzip) 838.105KiB 837.766KiB 347.000B
Mysql 2.049MiB 2.049MiB -707.000B
Mysql (gzip) 824.325KiB 824.670KiB -354.000B
Sqlite 1.962MiB 1.962MiB 327.000B
Sqlite (gzip) 788.392KiB 788.648KiB -262.000B

Copy link

codspeed-hq bot commented Dec 29, 2024

CodSpeed Performance Report

Merging #5100 will not alter performance

Comparing chore/refactor-driver-adapters-executor (2f520ae) with main (cc0167b)

Summary

✅ 11 untouched benchmarks

@jkomyno jkomyno requested review from jacek-prisma and removed request for wmadden December 30, 2024 13:05
@jkomyno jkomyno requested a review from jacek-prisma December 30, 2024 15:55
@jkomyno jkomyno merged commit aef02d5 into main Dec 30, 2024
367 checks passed
@jkomyno jkomyno deleted the chore/refactor-driver-adapters-executor branch December 30, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants