Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(schema-engine): get rid of toml -> Rust generation in json-rpc-api-build, which is now compatible with wasm32-unknown-unknown #5224

Merged
merged 10 commits into from
Mar 5, 2025

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Mar 4, 2025

This PR:

  • Closes ORM-778
  • Gets rid of toml -> Rust generation in json-rpc-api-build. Toml definitions are substituted with equivalent Rust struct/enum declarations, avoiding all the previous build-time shenanigans.
    • You can see the previous expanded macro in b1efb11.
  • Renames json-rpc-api-build into json-rpc-api
  • Enables wasm32-unknown-unknown usage of json-rpc-api

/integration

@jkomyno jkomyno requested a review from a team as a code owner March 4, 2025 20:13
@jkomyno jkomyno requested review from viktor-ferenczi, a team and wmadden and removed request for a team and viktor-ferenczi March 4, 2025 20:13
Copy link

codspeed-hq bot commented Mar 4, 2025

CodSpeed Performance Report

Merging #5224 will not alter performance

Comparing chore/json-rpc-refactoring (c56f830) with main (ebe9274)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

github-actions bot commented Mar 4, 2025

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.131MiB 2.131MiB 0.000B
Postgres (gzip) 858.518KiB 858.515KiB 3.000B
Mysql 2.094MiB 2.094MiB 0.000B
Mysql (gzip) 843.373KiB 843.371KiB 2.000B
Sqlite 2.004MiB 2.004MiB 0.000B
Sqlite (gzip) 808.099KiB 808.096KiB 3.000B

@jkomyno jkomyno removed the request for review from wmadden March 4, 2025 21:40
@jkomyno jkomyno added this to the 6.5.0 milestone Mar 4, 2025
@jacek-prisma
Copy link
Contributor

we're finally getting rid of the toml files! 😄

@jkomyno jkomyno requested a review from jacek-prisma March 5, 2025 14:28
@jkomyno jkomyno merged commit 56bd63f into main Mar 5, 2025
370 checks passed
@jkomyno jkomyno deleted the chore/json-rpc-refactoring branch March 5, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants