Mark Bookmark Methods as Deprecated (From Discussions #209) #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0nst4ntin
changed the title
|
@lihbr Please take a look if these changes align with your idea from the discussion or if you see anything wrong with handling this like I did? If you see nothing wrong I would merge this and tag a new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request marks the public methods for bookmarks as @deprecated since the new version (which would be 5.4.0)!
It has to be done, as the field will be removed from the prismic api on February 12 2025 (see #209)
I added tests to ensure the methods will still work without the field beeing present.
They will simply return an empty array (or null, if checked for a specific bookmark).