Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support groups in groups #16

Merged
merged 3 commits into from
Jun 20, 2024
Merged

feat: support groups in groups #16

merged 3 commits into from
Jun 20, 2024

Conversation

levimykel
Copy link
Collaborator

@levimykel levimykel commented Jun 6, 2024

Caution

Complete before merging:

Resolves: DT-2171

Description

This PR adds support for group fields nested within group fields. This is an upcoming Prismic feature.

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

@levimykel levimykel self-assigned this Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

size-limit report 📦

Path Size
dist/index.js 1.44 KB (0%)
dist/index.cjs 1.81 KB (0%)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (bd7f977) to head (e49feea).
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   86.10%   85.39%   -0.71%     
==========================================
  Files           7        7              
  Lines        1094     1082      -12     
  Branches       53       51       -2     
==========================================
- Hits          942      924      -18     
- Misses        152      158       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xrutayisire xrutayisire merged commit a215f71 into main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants