Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return all repeated items of a SharedSlice, not just the first item #548

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return all repeated items of a SharedSlice, not just the first item #548

wants to merge 1 commit into from
+1 −1

Conversation

nanorepublica
Copy link

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Current shared slices with repeated items will only return the first item. This causes GraphQL to error as it expects an Iterable but the data is returning an object.

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

@nanorepublica
Return all repeated items of a SharedSlice, not just the first item
32b0c74 
Let me know what other changes need to happen to get this merged!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nanorepublica